Repository navigation
fix(release): publish index rows in the engine reader's five-field contract - #3
Merged
Merged
Conversation
…ntract The engine's reference reader rejects unknown fields: its index validator accepts exactly id, title, platform, repo and tier per game row, so the richer catalog rows (kind, rating, genre, subgenre) made every release index unreadable with TN_REFERENCES_MALFORMED. Project the rows at publish time; rating, genre and kind stay in data/catalog.json, where this library needs them. Verified against the engine source contract at threenative-engine packages/engine-mcp/src/references.ts (IReferenceGameRow).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine cannot read our index.
validateReferenceIndexinthreenative-engine/packages/engine-mcp/src/references.tsaccepts exactlyid, title, platform, repo, tierper game row and rejects unknown fields, so v0.3's index fails withTN_REFERENCES_MALFORMED(four extra fields: kind, rating, genre, subgenre).This projects the published rows to that contract. Catalog keeps the rich fields for search and filtering; only the release asset is narrowed.
Verified:
npm test35/35,npm run release:assetsexit 0, index now has 48 rows with exactly the five accepted keys and 1363 stubs.